TodoMVC kotlin ktor

[javimartinez]

Part of #3611

[lihaoyi]

I think this can be fixed by de-denting all the lines in the usage block. The parser handling these is pretty fragile and doesn't tolerate extraneous whitespace

[lihaoyi]

I'm seeing http://localhost:8080/learn.json 404 Not Found in the web console, and the terminal logs have a similar error. Is something misconfigured?

[2582] [53] 2024-10-03 11:47:13.187 [eventLoopGroupProxy-4-1] TRACE io.ktor.routing.Routing - Trace for [webjars, todomvc-common, base.js]
[2582] [53] /, segment:0 -> SUCCESS @ /
[2582] [53]   /, segment:0 -> SUCCESS @ /
[2582] [53]     /(method:GET), segment:0 -> FAILURE "Not all segments matched" @ /(method:GET)
[2582] [53]   /active, segment:0 -> FAILURE "Selector didn't match" @ /active
[2582] [53]   /completed, segment:0 -> FAILURE "Selector didn't match" @ /completed
[2582] [53]   /save, segment:0 -> FAILURE "Selector didn't match" @ /save
[2582] [53]   /{id}, segment:1 -> SUCCESS; Parameters [id=[webjars]] @ /{id}
[2582] [53]     /{id}/delete, segment:1 -> FAILURE "Selector didn't match" @ /{id}/delete
[2582] [53]     /{id}/toggle, segment:1 -> FAILURE "Selector didn't match" @ /{id}/toggle
[2582] [53]   /toggle-all, segment:0 -> FAILURE "Selector didn't match" @ /toggle-all
[2582] [53] Matched routes:
[2582] [53]   No results
[2582] [53] Route resolve result:
[2582] [53]   FAILURE "No matched subtrees found" @ /
[2582] [53] 2024-10-03 11:47:13.187 [eventLoopGroupProxy-4-2] TRACE io.ktor.routing.Routing - Trace for [webjars, todomvc-common, base.css]
[2582] [53] /, segment:0 -> SUCCESS @ /
[2582] [53]   /, segment:0 -> SUCCESS @ /
[2582] [53]     /(method:GET), segment:0 -> FAILURE "Not all segments matched" @ /(method:GET)
[2582] [53]   /active, segment:0 -> FAILURE "Selector didn't match" @ /active
[2582] [53]   /completed, segment:0 -> FAILURE "Selector didn't match" @ /completed
[2582] [53]   /save, segment:0 -> FAILURE "Selector didn't match" @ /save
[2582] [53]   /{id}, segment:1 -> SUCCESS; Parameters [id=[webjars]] @ /{id}
[2582] [53]     /{id}/delete, segment:1 -> FAILURE "Selector didn't match" @ /{id}/delete
[2582] [53]     /{id}/toggle, segment:1 -> FAILURE "Selector didn't match" @ /{id}/toggle
[2582] [53]   /toggle-all, segment:0 -> FAILURE "Selector didn't match" @ /toggle-all
[2582] [53] Matched routes:
[2582] [53]   No results
[2582] [53] Route resolve result:
[2582] [53]   FAILURE "No matched subtrees found" @ /
[2582] [53] 2024-10-03 11:47:13.188 [eventLoopGroupProxy-4-3] TRACE io.ktor.routing.Routing - Trace for [webjars, todomvc-app-css, index.css]
[2582] [53] /, segment:0 -> SUCCESS @ /
[2582] [53]   /, segment:0 -> SUCCESS @ /
[2582] [53]     /(method:GET), segment:0 -> FAILURE "Not all segments matched" @ /(method:GET)
[2582] [53]   /active, segment:0 -> FAILURE "Selector didn't match" @ /active
[2582] [53]   /completed, segment:0 -> FAILURE "Selector didn't match" @ /completed
[2582] [53]   /save, segment:0 -> FAILURE "Selector didn't match" @ /save
[2582] [53]   /{id}, segment:1 -> SUCCESS; Parameters [id=[webjars]] @ /{id}
[2582] [53]     /{id}/delete, segment:1 -> FAILURE "Selector didn't match" @ /{id}/delete
[2582] [53]     /{id}/toggle, segment:1 -> FAILURE "Selector didn't match" @ /{id}/toggle
[2582] [53]   /toggle-all, segment:0 -> FAILURE "Selector didn't match" @ /toggle-all
[2582] [53] Matched routes:
[2582] [53]   No results
[2582] [53] Route resolve result:
[2582] [53]   FAILURE "No matched subtrees found" @ /
[2582] [53] 2024-10-03 11:47:13.191 [eventLoopGroupProxy-4-3] TRACE io.ktor.routing.Routing - Trace for [learn.json]
[2582] [53] /, segment:0 -> SUCCESS @ /
[2582] [53]   /, segment:0 -> SUCCESS @ /
[2582] [53]     /(method:GET), segment:0 -> FAILURE "Not all segments matched" @ /(method:GET)
[2582] [53]   /active, segment:0 -> FAILURE "Selector didn't match" @ /active
[2582] [53]   /completed, segment:0 -> FAILURE "Selector didn't match" @ /completed
[2582] [53]   /save, segment:0 -> FAILURE "Selector didn't match" @ /save
[2582] [53]   /{id}, segment:1 -> SUCCESS; Parameters [id=[learn.json]] @ /{id}
[2582] [53]     /{id}/delete, segment:1 -> FAILURE "Selector didn't match" @ /{id}/delete
[2582] [53]     /{id}/toggle, segment:1 -> FAILURE "Selector didn't match" @ /{id}/toggle
[2582] [53]   /toggle-all, segment:0 -> FAILURE "Selector didn't match" @ /toggle-all
[2582] [53] Matched routes:
[2582] [53]   No results
[2582] [53] Route resolve result:
[2582] [53]   FAILURE "No matched subtrees found" @ /

[lihaoyi]

As part of this PR, can you update 1-hello-ktor to use 8090 as its port, and 2-todo-ktor to user 8091. We currently don't have automatic port assignment set up, so we have to manually assign different ports to each integration test to avoid conflict when running in parallel

[lihaoyi]

One behavioral bug I found: when there are tasks stored, we should never hide the bottom All/Active/Completed bar, even if none of the tasks would be displayed in the current configuration. The bar should only be hidden when all tasks are deleted, not when they are hidden by filters

[javimartinez]

Thanks for the review @lihaoyi. I'll take a look to these comments over the weekend :)

[lihaoyi]

Looks great, @javimartinez if you're done with it I'll merge once tests pass

[javimartinez]

Looks great, @javimartinez if you're done with it I'll merge once tests pass

Yeah, I'm done :)

[lihaoyi]

Great! Email me your bank transfer details and I can send you the bounty