-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve file handling on Windows #3764
Improve file handling on Windows #3764
Conversation
…eOutputStream with Files.newOutputStream
Thanks @sake92! Might need to send a PR upstream to OS-Lib as well https://github.com/com-lihaoyi/os-lib/blob/f1bf225f8b110c4a561465717d8b13efcd9ee6d3/os/src/ZipOps.scala#L75 |
We also use |
Sure thing, I'll update it there too.
JarOutputStream is not OS-dependent like the
|
Changes:
new FileInputStream
withFiles.newInputStream
new FileOutputStream
withFiles.newOutputStream
Motivation:
#1939
https://bugs.openjdk.org/browse/JDK-6357433 (in a comment) says:
So seems like new NIO API does use, FILE_SHARE_DELETE, which is needed to delete files in unix-style.