Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the correct buildfile name in the progress #3847

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Show the correct buildfile name in the progress #3847

merged 3 commits into from
Oct 27, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Oct 26, 2024 •
edited
Loading

Instead of always using build.mill we now use the actual buildfile name in the progress logger.

> mill resolve _
[build.sc-57/61] compile
...

> mv build.sc build.mill.scala

> mill resolve _
[build.mill.scala-57/61] compile
...

Fix #3831

lefou added 3 commits October 26, 2024 10:58
@lefou
Show the correct buildfile name in the progress
cc80c57 
Instead of always using `build.mill` we now use the actual buildfile name in the progress logger.

```
> mill resolve _
[build.sc-57/61] compile
...
```

Fix com-lihaoyi#3831
@lefou
.
26d59d0
@lefou
Update error message and fix test
3e5cd0d
@lefou lefou requested a review from lihaoyi October 26, 2024 09:47
@lefou lefou merged commit fbc6e2e into com-lihaoyi:main Oct 27, 2024
24 checks passed
@lefou lefou deleted the buildfile-display branch October 27, 2024 16:20
@lefou lefou added this to the 0.12.2 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.2
Development

Successfully merging this pull request may close these issues.

Logger does not reflect the real build script name
2 participants
@lefou @lihaoyi