Allow users to customize coursier ResolutionParams #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Nov 13, 2024
|
The new task should definitely come with some documentation, since some other customizations seem to affect the final |
What do you mean? |
Oh, I think I see |
|
(seems the CI error is a flake) |
lefou
reviewed
Nov 19, 2024
They can be called in a legit fashion if the newly added non-mandatory argument isn't passed
lihaoyi
pushed a commit
that referenced
this pull request
Nov 22, 2024
coursier [`2.1.18`](https://github.com/coursier/coursier/releases/tag/v2.1.18) takes Maven "BOMs" better into account, which can sometimes significantly change the versions (or even the dependencies) selected by coursier (see also the [`2.1.17`](https://github.com/coursier/coursier/releases/tag/v2.1.17) release notes). #3949 offers a way to disable the new way of processing BOMs, if ever that's needed, with ```scala def resolutionParams = Task.Anon { super.resolutionParams().withEnableDependencyOverrides(Some(false)) } ``` coursier-interface is bumped along the way just in case. Its `1.0.24` version uses coursier `2.1.18` under-the-hood (in a hidden proguarded fashion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
JavaModule#resolutionParamstask, allowing users to customize coursier'sResolutionParams. These allow to customize some aspects of dependency resolution.In particular,
ResolutionParams#enableDependencyOverrides, when set toSome(false), disables the recent BOM changes added (and enabled by default) in coursier2.1.17. This might be useful, if ever users aren't happy with the versions it selects, or want to wait a bit before enabling that, or if they find out performance suffers because of it for them.The new task is anonymous (it's not a target, it's not serialized on disk), as
ResolutionParamshas a field that doesn't easily lend itself to serialization (rules, because of theRuletype, which is an open abstract class).