Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: #3963 Added Kotlin Spring Boot Example #3965

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

himanshumahajan138
Copy link
Contributor

@himanshumahajan138 himanshumahajan138 commented Nov 14, 2024

Pull Request

Added Kotlin Example for Spring Boot
Fixes: #3963

Description

Adds Example for Kotlin Spring Boot 6-hello-spring-boot and 7-todo-spring-boot

Related Issues

Checklist

  • New Example For Kotlin Spring Boot Hello World
  • New Example for Kotlin Spring Boot Todo MVC

Status

Completed Addition

@himanshumahajan138 himanshumahajan138 marked this pull request as draft November 14, 2024 15:06
@himanshumahajan138 himanshumahajan138 marked this pull request as ready for review November 14, 2024 17:08
@himanshumahajan138 himanshumahajan138 changed the title [WIP] Fixes: #3693 Issue (Please Don't Review Until WIP Tag) [WIP] Fixes: #3963 Added Kotlin Spring Boot Example Nov 14, 2024
@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Nov 15, 2024

@lihaoyi i need your guidance

actually, i had done first part but for second part i want to ask something

so tell me for the todo mvc application do i need to follow exact the same code as present in the javalib example ?

i am thinking of adding a good type of example and including some advanced crud, js and css so is this okay or you want to add something

and i think this will give user a broad view on how to use mill for kotlin spring boot

@lihaoyi
Copy link
Member

lihaoyi commented Nov 15, 2024

@himanshumahajan138 let's use the exact same Thymeleaf/JS/CSS as the Java example, just to keep things consistent. The only difference would be the build config and server implementation.

For people who want more fancy things there's the Ktor and Ktor-KotlinJS examples.

@himanshumahajan138
Copy link
Contributor Author

ok then working on this ✨

@himanshumahajan138
Copy link
Contributor Author

@lihaoyi It's Complete and i didn't played much with documentation part as i followed the way it was present in javalib/web

So Let's Finalize this and if anything required, please let me know...

Thanks...

@himanshumahajan138 himanshumahajan138 changed the title [WIP] Fixes: #3963 Added Kotlin Spring Boot Example Fixed: #3963 Added Kotlin Spring Boot Example Nov 16, 2024
@lihaoyi lihaoyi merged commit c193ce6 into com-lihaoyi:main Nov 17, 2024
27 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Nov 17, 2024

Looks good @himanshumahajan138 , I'll close out the bounty

@himanshumahajan138 himanshumahajan138 deleted the issue-3963-testing branch November 17, 2024 06:42
@lefou lefou added this to the 0.12.3 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kotlin Spring-Boot examples (500USD Bounty)
3 participants