Added support for Revapi #3974
Merged
Added support for Revapi #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaychandran
commented
Nov 15, 2024
|
@lihaoyi Please review. |
lihaoyi
reviewed
Nov 16, 2024
Comment on lines
+21
to
+23
| val oldFiles = revapiOldFiles() | ||
| val oldFile = oldFiles.head | ||
| val oldSupFiles = oldFiles.tail |
There was a problem hiding this comment.
This (and below) can be written more concisely as val oldFile +: oldSupFiles = revapiOldFiles()
There was a problem hiding this comment.
Not for Agg since it does not extend Seq.
lihaoyi
reviewed
Nov 16, 2024
|
Some nits but otherwise looks good! |
lihaoyi
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Revapi support for API analysis and change tracking to identify incompatibilities.
Resolves #3929.