Add first class Javascript/Typescript support to the Mill build tool #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
reviewed
Dec 3, 2024
lihaoyi
reviewed
Dec 3, 2024
lihaoyi
reviewed
Dec 3, 2024
example/javascriptlib/basic/6-client-server-realistic/build.mill
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Dec 3, 2024
lihaoyi
reviewed
Dec 3, 2024
lihaoyi
reviewed
Dec 3, 2024
lihaoyi
reviewed
Dec 3, 2024
5-client-server-hello/ 6-client-server-realistic/
… two modules, one a minimal JS server and one a minimal JS client, wired up and interacting
…ith two modules, one an Express server and one a React.js client, wired up and interacting, implementing a TodoMVC application
- running - bundling of a Node CLI tool - type checking - testing
- add npmDevDeps - use npmDeps & npmDevDeps - rename 1-simple mod qux to foo - mv jest dependencies into JestModule - use CreateReactAppModule
- fix compilation errors from prev merge
|
Seems like the client-server-realistic example still doesn't work??? |
|
lihaoyi
reviewed
Dec 8, 2024
lihaoyi
reviewed
Dec 8, 2024
lihaoyi
reviewed
Dec 8, 2024
example/javascriptlib/basic/4-multi-modules/library/src/library.ts
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Dec 8, 2024
example/javascriptlib/basic/4-multi-modules/library/test/library.test.ts
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Dec 8, 2024
lihaoyi
reviewed
Dec 8, 2024
lihaoyi
reviewed
Dec 8, 2024
example/javascriptlib/basic/5-client-server-hello/client/src/client.ts
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Dec 8, 2024
lihaoyi
reviewed
Dec 8, 2024
example/javascriptlib/basic/6-client-server-realistic/client/src/test/App.test.tsx
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Dec 8, 2024
| def serverMod = server | ||
| } | ||
|
|
||
| // Documentation for mill.example.javascriptlib |
There was a problem hiding this comment.
If you got your todomvc example from somewhere on the internet, you should include a link to it
There was a problem hiding this comment.
Its the react version of the example defined in scalalib.web
lihaoyi
reviewed
Dec 8, 2024
| import mill.* | ||
| import os.* | ||
|
|
||
| trait RsWithExpressModule extends TypeScriptModule { |
There was a problem hiding this comment.
Why do we need this? Why can't we just use the normal TypeScriptModule#run that the server module already comes with?
There was a problem hiding this comment.
moved to resources
- use simple example - use tsconfig-paths to resolve ts paths @ run
- rm RsWithExpressModule - use resources for client build
|
@monyedavid looks mostly good, just missing the link to where-ever you got the React.js TodoMVC example then I'll merge it |
|
Looks great, thanks @monyedavid . I'll close out the bounty using your existing bank details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#3927
Checklist