-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Native client #4057
Draft
Quafadas
wants to merge
20
commits into
com-lihaoyi:main
Choose a base branch
from
Quafadas:native_client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Native client #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use mill show runner.client.nativeLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start of an effort, to get a mill Scala Native client.
Here's what (seems) to be in place.
Unfortunately, I think this might be quite some way from a solution.
I've observed that the native client, appears to fire up a new server on every incarnation. Increasingly, I believe this may come down to some difference / bug / expected behaviour in how Scala Native interacts with files.
I can't seem to port some of the tests which handle file tailing operations, which seems to lend support to that idea.
If someone wants to play - on the branch of this PR branch.
mill runner.client.nativeLink
will emit a file at
out/runner/client/nativeLink.dest/out
.If I run an
installLocalCache
and run that file in the root of (say) a clone of upickle. I appear to get a (semi) functioning mill client. That starts a server every time (!)... but it does compile and run things. And it starts very quickly, so there;s that I guess.for #4016