Upgrade ammonite to 1.1.2-30-53edc31 #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are failing because the snapshot is not published for 2.11.8: not found: https://repo1.maven.org/maven2/com/lihaoyi/ammonite_2.11.8/1.1.2-28-e8b4996/ammonite_2.11.8-1.1.2-28-e8b4996.pom@lihaoyi Can the snapshot be published for 2.10/2.11 too? Otherwise I'll revert the change to ScalaModule and keep 1.1.2 there. |
smarter
force-pushed
the
upgrade-ammonite
branch
from
a9c1b00 to
3fa1ed3
Compare
smarter
changed the title
smarter
force-pushed
the
upgrade-ammonite
branch
2 times, most recently
from
23f6fe4 to
1bb9d6e
Compare
smarter
changed the title
smarter
force-pushed
the
upgrade-ammonite
branch
from
1bb9d6e to
fbed4f5
Compare
This is mainly to get com-lihaoyi/Ammonite#851 which should reduce the amount of unnecessary work done by incremental compilation in the Mill build. This requires some code changes since this means we now depend on a more recent version of coursier, as a side-effect this means that we do not depend on scalaz anymore. Also use the same ammonite version in the Mill build and in ScalaModule#ammoniteReplClasspath. Also remove an incorrect dependency in the caffeine integration test. This was always wrong but did not start failing until this commit, probably due to dependencies appearing in a different order on the classpath.
smarter
force-pushed
the
upgrade-ammonite
branch
from
a1c6767 to
1577821
Compare
|
There's one test failure that doesn't seem spurious, I have no idea what it means: [406/408] dev.upstreamAssembly
1 targets failed
publishVersion ammonite.ops.ShelloutException: CommandResult 128
fatal: bad object f424a857d8cd4435feb878b7cf9253f84814a93e
ammonite.ops.Shellout$.executeStream(Shellout.scala:101)
ammonite.ops.Shellout$.$anonfun$$percent$percent$1(Shellout.scala:15)
ammonite.ops.Command.applyDynamic(Shellout.scala:118)
ammonite.$file.build.$anonfun$publishVersion$4(build.sc:504)
mill.define.ApplyerGenerated.$anonfun$zipMap$2(ApplicativeGenerated.scala:7)
mill.define.Task$MappedDest.evaluate(Task.scala:348)any clue @lihaoyi ? |
|
dunno, is it reliably reproducible
…On Thu, 23 Aug 2018 at 7:38 PM, Guillaume Martres ***@***.***> wrote:
There's one test failure that doesn't seem spurious, I have no idea what
it means:
[406/408] dev.upstreamAssembly 1 targets failed
publishVersion ammonite.ops.ShelloutException: CommandResult 128
fatal: bad object f424a85
ammonite.ops.Shellout$.executeStream(Shellout.scala:101)
ammonite.ops.Shellout$.$anonfun$$percent$percent$1(Shellout.scala:15)
ammonite.ops.Command.applyDynamic(Shellout.scala:118)
ammonite.$file.build.$anonfun$publishVersion$4(build.sc:504)
mill.define.ApplyerGenerated.$anonfun$zipMap$2(ApplicativeGenerated.scala:7)
mill.define.Task$MappedDest.evaluate(Task.scala:348)
any clue @lihaoyi <https://github.com/lihaoyi> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#411 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA5A_D_xaYNnzCqIjEjvv9DFAzl-oxO8ks5uTpROgaJpZM4WHK3w>
.
|
|
It didn't trigger in #414 which contains the current PR, so I guess not. Should we merge anyway? |
|
re-triggering the job seems to make it fail reliably, at least the last 2-3 times i tried; probably worth investigating before merge |
|
or maybe you can just make sure #414 really-truly works and just merge that |
|
Googling seems to indicate the error message means there's git repository corruption: As long as #414 doesn't reproduce the same error, I'd be happy to consider this failure some kind of transient and merging 414 |
|
I've restarted #414 a couple of times and it always came back green, so let's go with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to get com-lihaoyi/Ammonite#851 which
should reduce the amount of unnecessary work done by incremental
compilation in the Mill build. This requires some code changes since
this means we now depend on a more recent version of coursier, as
a side-effect this means that we do not depend on scalaz anymore.
Also use the same ammonite version in the Mill build and in
ScalaModule#ammoniteReplClasspath.