Android: databinding compiler with view binding example #5888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaslabs
added a commit
to vaslabs-ltd/compose-samples-with-mill
that referenced
this pull request
Sep 18, 2025
vaslabs
added a commit
to vaslabs-ltd/compose-samples-with-mill
that referenced
this pull request
Sep 18, 2025
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.ci
vaslabs
changed the title
lefou
reviewed
Sep 21, 2025
libs/androidlib/src/mill/androidlib/AndroidDataBindingModule.scala
Outdated
Show resolved
Hide resolved
libs/androidlib/databinding-api/src/mill/androidlib/databinding/GenerateBindingSources.scala
Show resolved
Hide resolved
vaslabs
commented
Sep 22, 2025
libs/androidlib/databinding/impl/src/mill/androidlib/databinding/AndroidDataBindingImpl.scala
Show resolved
Hide resolved
vaslabs
commented
Sep 23, 2025
vaslabs
commented
Sep 23, 2025
some renamings configurable version
|
good job @souvlakias , thanks for the implementation. should be ready for review |
vaslabs
changed the title
|
@souvlakias almost forgot, can you annotate the new classes with experimental |
lefou
reviewed
Sep 26, 2025
libs/androidlib/src/mill/androidlib/databinding/AndroidDataBindingWorkerModule.scala
Show resolved
Hide resolved
libs/androidlib/src/mill/androidlib/databinding/AndroidDataBindingWorkerModule.scala
Show resolved
Hide resolved
libs/androidlib/databinding/src/mill/androidlib/databinding/AndroidDataBindingImpl.scala
Outdated
Show resolved
Hide resolved
|
retested after the changes 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5886
This PR allows for viewBinding to work via the databinding-compiler.
The option is enabled similarly with Gradle and Mill's compose flags.
It's implementation is adapted from the CLI tool here
Co-authored by @souvlakias
Jetchat example