-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation warnings #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing warnings is great! I added some minor comments/questions.
os/src/ListOps.scala
Outdated
@@ -15,12 +15,12 @@ import java.nio.file.attribute.BasicFileAttributes | |||
* them. You can disable sorted by passing in the flag `sort = false`. | |||
*/ | |||
object list extends Function1[Path, IndexedSeq[Path]] { | |||
def apply(src: Path, sort: Boolean = true) = { | |||
def apply(src: Path, sort: Boolean = true): Array[Path] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this one also return a IndexedSeq[Path]
? The other apply
and the inherited Functiona1
suggests it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
No description provided.