Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more specific in return type of make and /. #154

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Be more specific in return type of make and /. #154

merged 1 commit into from
Mar 2, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 2, 2023 •
edited
Loading

This results in nicer and more expected return types:

scala> os.root / "a" / "b"
val res0: os.Path = /a/b

whereas in previous versions, it contained one or multiple ThisType. E.g. on Scala 3.2

scala> os.root / "a" / "b"
val res0: os.root.ThisType#ThisType = /a/b

@lefou lefou merged commit 5d176e5 into com-lihaoyi:main Mar 2, 2023
@lefou lefou deleted the return-type-subpath branch March 2, 2023 18:01
@lefou lefou added this to the after 0.9.0 milestone Mar 2, 2023
@lihaoyi lihaoyi mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
1 participant
@lefou