-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zip
and unzip
API
#317
Merged
zip
and unzip
API
#317
Changes from 40 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
6058343
Introduce `zipIn` functionality to zip files and folders in a new zip…
chaitanyawaikar 4eb1c5f
Extend the `zipIn` functionality to append new files and folders to a…
chaitanyawaikar db8db8a
Implement the `unzip` functionality. This method would create a new d…
chaitanyawaikar 997444a
Refactoring zip functionality.
chaitanyawaikar ec795f3
Introduce new options in zip functionality
chaitanyawaikar 24d6ece
Fix delete option in zip files
chaitanyawaikar e76401a
Enhance unzip functionality with
chaitanyawaikar 8f0cd99
Add documentation support for zip and unzip functionality.
chaitanyawaikar 02ba84b
Fix scalafmt file changes
chaitanyawaikar 9444261
Fix error caused in build step `./mill -i -k __.mimaReportBinaryIssues`
chaitanyawaikar 6180cd8
Fix error caused in build step `./mill -i -k __.mimaReportBinaryIssues`
chaitanyawaikar f272471
Added scaladocs for the `zip` and `unzip` functionality
chaitanyawaikar ad952ec
Add `zip.stream` and `unzip.stream` functionality and their correspon…
chaitanyawaikar 8dc2fdb
Add functionality `preserveMTimes` and `preservePermissions` during z…
chaitanyawaikar 6fdac49
wip
lihaoyi 9e8b6a6
wip
lihaoyi 515c1d9
wip
lihaoyi 86eae3d
wip
lihaoyi 3a2a529
move to filesystem append
lihaoyi 7bc41b8
wip
lihaoyi f006abe
wip
lihaoyi eaf15ad
update CI
lihaoyi 5cf2705
versions
lihaoyi cdd7034
.
lihaoyi eba11f9
fmt
lihaoyi f140105
fmt
lihaoyi ea2a1e6
fmt
lihaoyi 57a6144
fmt
lihaoyi 0a223e2
.
lihaoyi 9fc2526
.
lihaoyi 8b89c46
.
lihaoyi 32a4e45
.
lihaoyi b337b1f
.
lihaoyi 182c390
.
lihaoyi dee6790
.
lihaoyi a2176d1
.
lihaoyi 0e6a13e
.
lihaoyi cc51ba9
.
lihaoyi d8db7bb
.
lihaoyi abf6a92
.
lihaoyi da66cee
.
lihaoyi 867ee9f
.
lihaoyi 5c1bfee
.
lihaoyi ce621b7
.
lihaoyi 113ed16
.
lihaoyi 54dae26
.
lihaoyi c401529
.
lihaoyi cb43974
.
lihaoyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that? Is this just convenient or necessary? I'd like to avoid dropping support for a Java version in a minor release. If we need to drop it, we should bump to
0.11.0
. Keeping bin-compat with0.10.x
is a bonus feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just convenience really, but i realized we already have
os.Internal.transfer
so I can just use that just as convenientlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there's some issue with zip filesystem on windows java 8, so need to bump that to java 11 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think given that we now have 2/3 OSs only testing on Java 11, let's just bump the official supported version to 11. People can continue to try using it on 8, it'll just be at their own risk