Propagate content length from filesystem through geny.Writable and os.Source
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
added a commit
to com-lihaoyi/mill
that referenced
this pull request
Oct 8, 2024
Pulls in com-lihaoyi/os-lib#320 which should let us remove the workaround in 561a007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means downstream libraries like Requests-Scala or Cask can properly set the content length when handling
os.read.streams and similar values in their HTTP requests or responsesNoticed the lack of this when uploading to github failed in com-lihaoyi/mill#3686 due to the lack of content length header in the upload
Covered by unit tests