Retry flaky tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lolgab
force-pushed
the
retry-flaky-tests
branch
from
fbc06c0
to
c5dde1c
Compare
lefou
reviewed
Jan 31, 2022
There was a problem hiding this comment.
10 retries looks a bit too high and reduces my confidence.
Also, maybe we should make this conditional or configurable, e.g. by an env var TEST_RETRY_COUNT which we set in the build? We could check for CI or GITHUB_ACTIONS (https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables), so that we don't retry when testing locally (and possibly shadow malfunction).
|
I tried with 5 and it failed on Mac OS. Actually I can configure the retry to 10 only on mac and on Github Actions. What do you think @lefou ? |
|
I think Linux is also failing sometimes. If you retry only on GITHUB, I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retries the flaky watch tests we have