Distinguish SVG attributes that do not overlap with HTML attributes #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change creates a
SVGOnlyAttrs
trait that contains all the attributes that are unique to SVG (in the sense of not being members of theAttrs
trait). The existingSVGAttrs
trait is then formed by extending this trait with the few overlapping members.In this way
SVGAttrs
remains fully backwards-compatible, but we are able to define a single object to hold all attributes, e.g. (whereST
isscalatags.Text
):with is useful when working with SVG embedded in HTML. (One can alias all tags as <, all styles as ^ and all attributes as *, for example.)