Rename tests method to more explicit names #107
Assignees
Labels
enhancement
New feature or request
Comments
|
Similar request: Refactor tests structure in compas-sct |
samirromdhani
added a commit
that referenced
this issue
Aug 28, 2023
samirromdhani
added a commit
that referenced
this issue
Aug 30, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update HeaderAdapterTest update DOAdapterTest update related elementXPath test remove AbstractComLevel update CommunicationAdapterTest update ConnectedAPAdapterTest update SubNetworkAdapterTest update BDAAdapterTest, remove usage of AbstractDTTLevel update HeaderAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Aug 30, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update HeaderAdapterTest update DOAdapterTest update related elementXPath test remove AbstractComLevel update CommunicationAdapterTest update ConnectedAPAdapterTest update SubNetworkAdapterTest update BDAAdapterTest, remove usage of AbstractDTTLevel update HeaderAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Aug 30, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update HeaderAdapterTest update DOAdapterTest update related elementXPath test remove AbstractComLevel update CommunicationAdapterTest update ConnectedAPAdapterTest update SubNetworkAdapterTest update BDAAdapterTest, remove usage of AbstractDTTLevel update HeaderAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Aug 31, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Aug 31, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Aug 31, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Sep 1, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update class name AbstractDTTLevel to DataTypeTemplateTestUtils Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.ied package add tag in ExtRefServiceTest update InputsAdapterTest update IEDAdapterTest update DOIAdapterTest update DataSetAdapterTest update DAITrackerTest update ControlBlockAdapterTest update AccessPointAdapterTest
samirromdhani
added a commit
that referenced
this issue
Sep 1, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update class name AbstractDTTLevel to DataTypeTemplateTestUtils Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.ied package add tag in ExtRefServiceTest update InputsAdapterTest update IEDAdapterTest update DOIAdapterTest update DataSetAdapterTest update DAITrackerTest update ControlBlockAdapterTest update AccessPointAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Sep 1, 2023
…os, closes #107, #196, #306 remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.dtt package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ExtRefServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.sstation package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update class name AbstractDTTLevel to DataTypeTemplateTestUtils Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in scl.ied package add tag in ExtRefServiceTest update InputsAdapterTest update IEDAdapterTest update DOIAdapterTest update DataSetAdapterTest update DAITrackerTest update ControlBlockAdapterTest update AccessPointAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Sep 4, 2023
refactor test code to use AssertJ and using Gherkin to define scenarios remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT update test classes in scl.dtt package update ExtRefServiceTest update test classes in scl.sstation package update class name AbstractDTTLevel to DataTypeTemplateTestUtils update test classes in scl.ied package add tag in ExtRefServiceTest update InputsAdapterTest update IEDAdapterTest update DOIAdapterTest update DataSetAdapterTest update DAITrackerTest update ControlBlockAdapterTest update AccessPointAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> add Tag=issue-321 to tests that should be isolated and respect F(I)RST principles of testing. Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in commons.dto package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in commons.util package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ObjectReferenceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update SclElementsProviderServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update sct app module Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ScdExceptionTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update sct data module Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> sonar review Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test method name Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
added a commit
that referenced
this issue
Sep 6, 2023
refactor test code to use AssertJ and using Gherkin to define scenarios remove TODOs related to isolated test rule: another issue will cover that update SclRootAdapterTest update RootSDIAdapterTest & SDIAdapterTest update LNAdapterTest refactor(#107, #196, #306): add tag to tests that should be respect isolation principal and best practice update LN0AdapterTest, LNAdapterTest, SDIAdapterTest.. update test classes in scl.com package update HeaderAdapterTesT update test classes in scl.dtt package update ExtRefServiceTest update test classes in scl.sstation package update class name AbstractDTTLevel to DataTypeTemplateTestUtils update test classes in scl.ied package add tag in ExtRefServiceTest update InputsAdapterTest update IEDAdapterTest update DOIAdapterTest update DataSetAdapterTest update DAITrackerTest update ControlBlockAdapterTest update AccessPointAdapterTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> add Tag=issue-321 to tests that should be isolated and respect F(I)RST principles of testing. Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in commons.dto package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test classes in commons.util package Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ObjectReferenceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update SclElementsProviderServiceTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update sct app module Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update ScdExceptionTest Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update sct data module Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> sonar review Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> update test method name Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor tests structure :review Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor tests structure :review - same test name pattern Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor tests structure: remove unused SclMockedElement class Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A good convention is something like :
methodName_should_do_somethingmethodName_when_condition_should_do_somethingmethodName_when_condition_should_throw_exceptionThe text was updated successfully, but these errors were encountered: