Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSR-463] - Add Private compas:SclFileType in /SCL when a new SCD file is created #88

Closed
DamienPERNET opened this issue Apr 4, 2022 · 0 comments · Fixed by #102
Closed
Assignees
Milestone

Comments

@DamienPERNET
Copy link
Contributor

DamienPERNET commented Apr 4, 2022

The goal of this US is to add when a new SCD file is created, the Private compas:SclFileType into the SCD header.

 

Prerequisites: 

  • The following COMPAS services have already been developed:
    • RSR-31 and RSR-384  to create a new SCD file with a specific Header.Id

 

The inputs of this service are:

  • A SCD file (required) defined by Header.id, Header.version and Header.revision

 

US process description:

  •  Step 1)
    • When a new SCD file is created by calling COMPAS service RSR-31 by using the SCD Header @id @Version @revision and Hitem attributes provided as input then add into the SCD header the Private /SCL/Private @type="COMPAS-SclFileType"/compas:SclFileType @xmlns:compas="https://www.lfenergy.org/compas/extension/v1" @name="SCD"

 

Output:

The SCD file has been created with Header attributes and Hitem attributes provided as input and it has been completed with Private compas:SclFileType

 

Error messages:

  • None

 

Acceptance criteria:

  • Check that all newly created SCD file has into its header, the Private /SCL/Private @type="COMPAS-SclFileType"/compas:SclFileType @xmlns:compas="https://www.lfenergy.org/compas/extension/v1" @name="SCD"

 

@DamienPERNET DamienPERNET changed the title [RSR-463] - Add Private compas:SclFileType in the header when a new SCD file is created [RSR-463] - Add Private compas:SclFileType in /SCL when a new SCD file is created Apr 21, 2022
@AliouDIAITE AliouDIAITE added this to the 0.0.4 milestone Apr 21, 2022
AliouDIAITE added a commit that referenced this issue May 4, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
@AliouDIAITE AliouDIAITE linked a pull request May 4, 2022 that will close this issue
@AliouDIAITE AliouDIAITE self-assigned this May 4, 2022
@AliouDIAITE AliouDIAITE linked a pull request May 4, 2022 that will close this issue
AliouDIAITE added a commit that referenced this issue May 10, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 10, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 10, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 10, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 13, 2022
…ement and Element

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 18, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 19, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 31, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 31, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue May 31, 2022
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE added a commit that referenced this issue Jun 2, 2022
[#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
SaintierFr pushed a commit to SaintierFr/compas-sct that referenced this issue Jun 20, 2022
…as#102)

[com-pas#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: aDiaite <62600667+AliouDIAITE@users.noreply.github.com>
SaintierFr pushed a commit that referenced this issue Jun 20, 2022
[#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: aDiaite <62600667+AliouDIAITE@users.noreply.github.com>
SaintierFr added a commit that referenced this issue Jun 22, 2022
* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP refactoring and test needed

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP add files and tests, refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : moving code to subnetwork and refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete not yet used code

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : refactoring after remarks for pull request

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete commented code and update pom.xml

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Added CII Best Practices Badge + removed unused LFX Security Tool badge

Signed-off-by: Flurb <private@tjalma.com>

* [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102)

[#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#70] : all updatable DA should be returned

Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>

Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Co-authored-by: Flurb <private@tjalma.com>
Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
AliouDIAITE added a commit that referenced this issue Aug 17, 2022
* Added Github Action for release compas-sct (#53)

* Added releasing action & changed copyright to RTE FRANCE

Added releasing action & changed copyright to RTE FRANCE

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

* Updated automate projects action

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

* Release 0.0.4 (#103)

* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP refactoring and test needed

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP add files and tests, refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : moving code to subnetwork and refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete not yet used code

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : refactoring after remarks for pull request

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete commented code and update pom.xml

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Added CII Best Practices Badge + removed unused LFX Security Tool badge

Signed-off-by: Flurb <private@tjalma.com>

* [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102)

[#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#70] : all updatable DA should be returned

Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>

Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Co-authored-by: Flurb <private@tjalma.com>
Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Co-authored-by: Samir Romdhani <76203423+samirromdhani@users.noreply.github.com>
Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Co-authored-by: Flurb <private@tjalma.com>
Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
samirromdhani pushed a commit that referenced this issue Sep 12, 2022
* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Update SCL communication import method to allow the import of the att… (#91)

* Update SCL communication import method to allow the import of the attributes Address et PhysConn if present.

Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65] : correcting history for automation service

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#65 ==> 95] : correcting history for automation service: add test

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP refactoring and test needed

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP add files and tests, refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : moving code to subnetwork and refactoring

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete not yet used code

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : WIP to be refactored

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : refactoring after remarks for pull request

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#66] : delete commented code and update pom.xml

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* Added CII Best Practices Badge + removed unused LFX Security Tool badge

Signed-off-by: Flurb <private@tjalma.com>

* [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102)

[#88] : add private COMPAS_SCL_FILE_TYPE in created SCD

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* [#70] : all updatable DA should be returned

Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>

Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Co-authored-by: Flurb <private@tjalma.com>
Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants