Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(231): Automatic binding: Edit InRef from ExtRef #233

Merged
merged 1 commit into from
Feb 15, 2023
Merged

feat(231): Automatic binding: Edit InRef from ExtRef #233

merged 1 commit into from
Feb 15, 2023

Conversation

SaintierFr
Copy link
Member

Edit InRef DAI/Val from ExtRef attributes

Signed-off-by: SaintierFr 99645240+SaintierFr@users.noreply.github.com

@SaintierFr SaintierFr linked an issue Feb 3, 2023 that may be closed by this pull request
[RSR-633] - Automated Binding - Edit InRef #231
Closed
@SaintierFr SaintierFr self-assigned this Feb 3, 2023
@SaintierFr SaintierFr force-pushed the 231-automated-binding-edit-inref branch from 0f917bb to ccfa68a Compare February 3, 2023 10:03
samirromdhani
samirromdhani reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@samirromdhani samirromdhani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the following fields to be constants rather than Hard-coded string or method variables : purpose, setSrcRef, setSrcCB, setTstRef and setTstCB
Also the prefix InRef can join the constants list.

@massifben
Copy link
Contributor

General comment : use AssertJ for assertion in tests.

massifben
massifben reviewed Feb 8, 2023
View reviewed changes
@SaintierFr SaintierFr force-pushed the 231-automated-binding-edit-inref branch from 2191753 to dc5b61f Compare February 13, 2023 09:13
@samirromdhani samirromdhani force-pushed the 231-automated-binding-edit-inref branch 5 times, most recently from 7f02ea2 to 5d0bcff Compare February 15, 2023 10:15
@SaintierFr
feat(231): Automatic binding: Edit InRef from ExtRef
de1a01d 
Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
@SaintierFr SaintierFr force-pushed the 231-automated-binding-edit-inref branch from 35ca781 to de1a01d Compare February 15, 2023 13:04
@SaintierFr SaintierFr merged commit b2a9cc8 into develop Feb 15, 2023
@SaintierFr SaintierFr deleted the 231-automated-binding-edit-inref branch February 15, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samirromdhani samirromdhani samirromdhani approved these changes

@massifben massifben massifben left review comments

Assignees

@SaintierFr SaintierFr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RSR-633] - Automated Binding - Edit InRef
3 participants
@SaintierFr @massifben @samirromdhani