Release #322
Merged
Release #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
…put-command-is-deprecated-take-place-in-sonarcloud-analysis fix deprecating set-output command in sonarcloud-analysis manifests yaml
…ods with instance methods closes #110 BREAKING CHANGE: 💥 in sct-commons: The services which provide static methods are moved from scl to commons package. Now those services implements interfaces, no static methods. Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package. Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): give PrivateService the new name PrivateUtils and change the package from scl to util. Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110 refactor(#110): update SclAutomationService Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): check review part1 use @requiredargsconstructor, instead of @NoArgsConstructor. use Camel case for PrivateLinkedToStds Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): check review part2 [use mockito properly] Remove unused test package. Use latest version of mockito. Fix related to version 5.4.0 Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): review part3 [naming] remove prefix 'I' and add suffix 'Editor' The interfaces are moved from scl to api package. add package doc Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): review part4 [seperate SclService features ] SclEditor (interface) spec are reduced by adding ReadOnly and Write One Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor(#110): sonar review Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> docs(#110): update demo project and quickstart page Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
…r-services-and-replace-static-methods-with-instance-methods Create interface for Services and replace static methods with instance methods closes #110
massifben
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix deprecating set-output command in sonarcloud-analysis manifests yaml in #317
Create interface for Services and replace static methods with instance methods in #318