Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade github action dependencies for required node and pnpm versions #494

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

tukib
Copy link
Member

@tukib tukib commented Nov 30, 2024

Problem

Our build scripts depend on pnpm/action-setup and actions/setup-node, which rely on Node 16 according to build artifact logs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

As Node 16 is now EOL in GitHub Actions (since Nov 12), we should pin the dependencies to the Node 20 as recommended (and correctly reflecting our package.json)

Context

pnpm/action-setup@v2 -> pnpm/action-setup@v4
actions/setup-node@v3 -> actions/setup-node@v4

I have also bumped the pnpm version to 9, as this is the correct version for the current checked in lock file (resolves #484).

I've initially submitted these changes together in anticipation that these dependencies are tightly coupled / to prevent spurious errors, and because our local development environments have been using pnpm 9 and Node 20 already without issues.

@tukib tukib requested a review from a team as a code owner November 30, 2024 03:39
@tukib tukib mentioned this pull request Nov 30, 2024
@tukib tukib added the dependencies Pull requests that update a dependency file label Nov 30, 2024
@tukib
Copy link
Member Author

tukib commented Nov 30, 2024

From what I can tell from the linked repos, no other workflow configuration changes are needed to migrate.

@seanmakesgames seanmakesgames merged commit 7f30066 into main Nov 30, 2024
4 checks passed
@seanmakesgames seanmakesgames deleted the tukib/gh-actions-upgrade branch November 30, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pnpm lockfile version
3 participants