[OPIK-655]: finish initial dataset UI #1016
Conversation
| const flattenedDatasetItem = flattenObject(datasetItem); | ||
|
|
||
| const notDefinedVariables = messageTags.filter((tag) => | ||
| isUndefined(flattenedDatasetItem[tag]), | ||
| ); |
There was a problem hiding this comment.
Maybe better to replace the flattenObject with the lodash get instead?
|
|
||
| return { | ||
| role: message.role, | ||
| content: mustache.render(message.content, datasetItem), |
There was a problem hiding this comment.
Probably we need extra logic here in case we pass an object since mustache is using toString instead of JSON.stringify for replacing the values
| async (task) => { | ||
| await createTraceSpan(task); | ||
| }, |
There was a problem hiding this comment.
Just passing createTraceSpan should be okay, right?
| (combination: DatasetItemPromptCombination, callback) => { | ||
| processCombination(combination, callback); | ||
| }, |
There was a problem hiding this comment.
I don't believe the callback here is actually needed if you just return the Promise from processCombination like:
asyncLib.mapLimit(
combinations,
LIMIT_STREAMING_CALLS,
processCombination,
() => {
setIsRunning(false);
isToStopRef.current = false;
abortControllersOngoingRef.current.clear();
},
);And removing the processCallback(null) calls
| useEffect(() => { | ||
| // stop streaming whenever the location changes | ||
| return () => stopAll(); | ||
| }, [location, stopAll]); |
There was a problem hiding this comment.
I'd remove the location dependency since it's prone to error in case in the future we introduce search/hash locations in the Playground, just removing the dependency should do the trick and it'll be called on unmount the component
Details
Core features:
zustandin order to avoid re-rendering components. Each output and prompt is re-rendered only when it is changed now. The store is connected to the localStorage. The key has changed, so all previous playgrounds will be reset.asynclibraryIssues
Resolves #
Testing
Documentation