[OPIK-595] Automation rule evaluator cache #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldaugusto
approved these changes
Jan 15, 2025
| @@ -50,50 +50,54 @@ public Object invoke(MethodInvocation invocation) throws Throwable { | |||
| var cacheable = method.getAnnotation(Cacheable.class); | |||
| if (cacheable != null) { | |||
| return runCacheAwareAction(invocation, isReactive, cacheable.name(), cacheable.key(), | |||
| (key, name) -> processCacheableMethod(invocation, isReactive, key, name, cacheable)); | |||
| (key, group) -> processCacheableMethod(invocation, isReactive, key, group, cacheable)); | |||
| } | |||
|
|
|||
| var cachePut = method.getAnnotation(CachePut.class); | |||
| if (cachePut != null) { | |||
There was a problem hiding this comment.
Is @cACHEpUT used anywhere? I could find @Cacheable and @CacheEvict, but not this one.
There was a problem hiding this comment.
Not yet, but the idea was to create a simple mechanism covering the most general cases. I guess the Cache Put makes more sense for get-by-id cases to update the cache.
thiagohora
deleted the
thiagohora/OPIK-595_automation_rule_evaluator_cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add Redis cache to automation rules evaluator
Issues
OPIK-595