NO-OPIK fix locator for next page buttons #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
approved these changes
Jan 20, 2025
Comment on lines
+11
to
+16
| self.next_page_button_locator = ( | ||
| self.page.locator("div") | ||
| .filter(has_text=re.compile(r"^Showing (\d+)-(\d+) of (\d+)")) | ||
| .nth(2) | ||
| .locator("button:nth-of-type(3)") | ||
| ) |
There was a problem hiding this comment.
Minor: code is repeated multiple times, feel free to centralise it in some way, to avoid copying & pasting.
There was a problem hiding this comment.
Good point, will spend some time doing some general code cleanup in the near future and will try to centralize most repeating methods/locators between pages into a single parent class that they can all inherit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Traces tests got broken because adding a 4th tab above the tables interfered with the locator for the next page button that was being used. Changed the locator everywhere to cover this and any possible future changes.