NO-JIRA: Remove amd64 architecture from docker compose #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyaka
approved these changes
Nov 22, 2024
andrescrz
deleted the
andrescrz/NO-JIRA-remove-amd64-architecture-docker-compose
branch
aadereiko
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The Opik backend and frontend containers were hardcoded to be built on
linux/amd64.Removed that, so it builds in the native architecture of the user, such as arm64 etc.
Issues
N/A
Testing
I run
docker compose -f docker-compose.yaml -f docker-compose.override.yaml up -d --buildprior and after the change in my local Mac with arm64 architecture.Prior to the change, the containers where built as amd64 and run in emulated mode.
After the change, they were built as arm64 and run natively.
Documentation