[OPIK-441] Split feedback score name endpoints #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
force-pushed
the
thiagohora/OPIK-441_split_feedback_score_name_endpoints
branch
from
18ae3cd to
1880d4a
Compare
idoberko2
reviewed
Nov 25, 2024
Comment on lines
263
to
265
| .getExperimentsFeedbackScoreNames(experimentIds) | ||
| .map(names -> names.stream().map(FeedbackScoreNames.ScoreName::new).toList()) | ||
| .map(FeedbackScoreNames::new) |
There was a problem hiding this comment.
I believe this logic belongs in the service layer
idoberko2
reviewed
Nov 25, 2024
Comment on lines
283
to
285
| .getSpanFeedbackScoreNames(projectId, type) | ||
| .map(names -> names.stream().map(FeedbackScoreNames.ScoreName::new).toList()) | ||
| .map(FeedbackScoreNames::new) |
There was a problem hiding this comment.
I believe this logic belongs in the service layer
idoberko2
reviewed
Nov 25, 2024
Comment on lines
314
to
316
| .getTraceFeedbackScoreNames(projectId) | ||
| .map(names -> names.stream().map(FeedbackScoreNames.ScoreName::new).toList()) | ||
| .map(FeedbackScoreNames::new) |
idoberko2
reviewed
Nov 25, 2024
Comment on lines
436
to
441
| private static Mono<List<String>> getNames(Statement statement) { | ||
| return makeMonoContextAware(bindWorkspaceIdToMono(statement)) | ||
| .flatMapMany(result -> result.map((row, rowMetadata) -> row.get("name", String.class))) | ||
| .distinct() | ||
| .collect(Collectors.toList()); | ||
| } |
There was a problem hiding this comment.
I always prefer private methods to come after the public ones. Can you move it to be below the public methods?
idoberko2
reviewed
Nov 25, 2024
|
|
||
| webTarget = webTarget.queryParam("project_id", projectId); | ||
|
|
||
| List<String> expectedNames = names; |
idoberko2
reviewed
Nov 25, 2024
thiagohora
force-pushed
the
thiagohora/OPIK-441_split_feedback_score_name_endpoints
branch
from
be6e39e to
5ccdefd
Compare
idoberko2
approved these changes
Nov 25, 2024
thiagohora
deleted the
thiagohora/OPIK-441_split_feedback_score_name_endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation