[OPIK-448] [FE] UI on editing feedback score is slow #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferc
approved these changes
Nov 26, 2024
Comment on lines
+65
to
+84
| // make optimistic update for compare experiments | ||
| setExperimentsCompareCache(queryClient, traceParams, deleteMutation); | ||
|
|
||
| if (params.spanId) { | ||
| // make optimistic update for spans | ||
| setSpansCache( | ||
| queryClient, | ||
| { | ||
| traceId: params.traceId, | ||
| spanId: params.spanId, | ||
| }, | ||
| deleteMutation, | ||
| ); | ||
| } else { | ||
| // make optimistic update for traces | ||
| setTracesCache(queryClient, traceParams, deleteMutation); | ||
|
|
||
| // make optimistic update for trace | ||
| setTraceCache(queryClient, traceParams, deleteMutation); | ||
| } |
| @@ -41,23 +55,51 @@ const useTraceFeedbackScoreDeleteMutation = () => { | |||
| variant: "destructive", | |||
| }); | |||
| }, | |||
| onMutate: async (params: UseTraceFeedbackScoreDeleteMutationParams) => { | |||
There was a problem hiding this comment.
We have to add the queryClient.cancelQueries(...) step here -> https://tanstack.com/query/v5/docs/framework/react/guides/optimistic-updates#updating-a-single-todo
If not we could face some race conditions like:
- You start the mutation
A-> makes optimistic update (update cache) -> triggers request - Mutation
Afinishes and it's running theonSettledcallback (refetch) - You make another mutation
B-> makes optimistic update (A+Bupdates in the cache ✅ ) -> triggers request - Mutation
Afinishes the refetch -> updates the cache withAchange (reverts last mutation from an old server-state) ❌ - Eventually mutation
Bfinishes the refetch -> updates the cache andA+Bchanges are in the cache ✅
So with cancellation of the queries step we remove the misleading old state of the step 4
There was a problem hiding this comment.
Yes, you are right. Thanks for flagging this scenario. I have created a new PR with suggested improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add the optimistic update for all cases when the user sets/ edits /deletes the feedback score
Issues
Resolves #694
Testing
Documentation