[OPIK-457] Fix Redis lock keys leak #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
force-pushed
the
thiagohora/OPIK-457_fix_redis_lock_key_leak
branch
from
a13cc2f to
bffc42a
Compare
andrescrz
approved these changes
Nov 27, 2024
Comment on lines
+32
to
+33
| __ -> log.debug("Lock {} released successfully", locked), | ||
| __ -> log.warn("Lock {} already released", locked)); |
There was a problem hiding this comment.
Minor: wrap escaped values in the logs between single quotes.
There was a problem hiding this comment.
Adding both in a next review
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; |
There was a problem hiding this comment.
Minor: please clean up all these JUnit assertions and move to assertJ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Radisson doesn't delete a lock key from Redis after releasing it by default. To tackle this issue, we are adding a new configuration,
ttlInSeconds. This configuration will be used to set a ttl time for the lock every time a thread acquires a lock.Issues
OPIK-457
Testing