[OPIK-493] Fix Redis setup to properly config database indexes #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/RedisConfig.java
Outdated
Show resolved
Hide resolved
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
|
|
||
| public record RedisUrlParser(String scheme, String host, int port, int database) { |
There was a problem hiding this comment.
Why do we need all these params? They are never used apart from tests. Only database is used.
There was a problem hiding this comment.
Because a dto with only the database index is not reusable
idoberko2
reviewed
Dec 2, 2024
apps/opik-backend/src/test/java/com/comet/opik/infrastructure/redis/RedisUrlParserTest.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Dec 2, 2024
apps/opik-backend/src/test/java/com/comet/opik/infrastructure/redis/RedisUrlParserTest.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Dec 2, 2024
apps/opik-backend/src/test/java/com/comet/opik/infrastructure/redis/RedisUrlParserTest.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Dec 2, 2024
apps/opik-backend/src/test/java/com/comet/opik/infrastructure/redis/RedisUrlTest.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Dec 2, 2024
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/redis/RedisUrl.java
Show resolved
Hide resolved
thiagohora
force-pushed
the
thiagohora/OPIK-493_fix_redis_setup_to_properly_config
branch
from
85195d7 to
a1bf279
Compare
idoberko2
previously approved these changes
Dec 2, 2024
… of https://github.com/comet-ml/opik into thiagohora/OPIK-493_fix_redis_setup_to_properly_config
thiagohora
force-pushed
the
thiagohora/OPIK-493_fix_redis_setup_to_properly_config
branch
from
649280f to
7d00654
Compare
idoberko2
approved these changes
Dec 2, 2024
thiagohora
deleted the
thiagohora/OPIK-493_fix_redis_setup_to_properly_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The database index in the Redis URL was ignored since Redisson requires it to be defined at the Config class level.
Issues
OPIK-493