Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-133] [SDK] Implement batching for trace creation #790

Merged
merged 12 commits into from
Dec 4, 2024
Merged

[OPIK-133] [SDK] Implement batching for trace creation #790

merged 12 commits into from
Dec 4, 2024
+341 −135

Conversation

japdubengsub
Copy link
Contributor

@japdubengsub japdubengsub commented Dec 2, 2024 •
edited
Loading

Details

Added batch processing and sending for "create trace" messages.

Testing

Test are added/updated.

@japdubengsub japdubengsub changed the title OPIK-133 OPIK-133 [SDK] Implement batching for trace creation Dec 3, 2024
@japdubengsub japdubengsub changed the title OPIK-133 [SDK] Implement batching for trace creation [OPIK-133] [SDK] Implement batching for trace creation Dec 3, 2024
@japdubengsub japdubengsub marked this pull request as ready for review December 3, 2024 18:06
@japdubengsub japdubengsub requested a review from a team as a code owner December 3, 2024 18:06
alexkuzmik
alexkuzmik requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@alexkuzmik alexkuzmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a new e2e test where 2 tracked functions are called in a row (in the 2 traces with one span each should be created).
Our SDK is very sensitive to this feature, so it would be nice to have such a test.

sdks/python/src/opik/message_processing/batching/create_message_batcher.py Outdated Show resolved Hide resolved
sdks/python/src/opik/message_processing/messages.py Outdated Show resolved Hide resolved
alexkuzmik
alexkuzmik approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@alexkuzmik alexkuzmik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
And good work on outdated/incorrect tests update.

@alexkuzmik alexkuzmik merged commit 1d0d5ea into main Dec 4, 2024
23 checks passed
@alexkuzmik alexkuzmik deleted the OPIK-133 branch December 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkuzmik alexkuzmik alexkuzmik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japdubengsub @alexkuzmik