Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-523] batch delete for prompts #806

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

idoberko2
Copy link
Contributor

Details

This PR adds batch delete for prompts, similarly to #774

Issues

OPIK-523

Testing

Added an E2E test covering the new logic.

@idoberko2 idoberko2 requested a review from a team as a code owner December 4, 2024 08:20
@idoberko2 idoberko2 self-assigned this Dec 4, 2024
BorisTkachenko
BorisTkachenko previously approved these changes Dec 4, 2024
Copy link
Contributor

@BorisTkachenko BorisTkachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have one question.

Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to polish and it should be ready to go.

@idoberko2 idoberko2 merged commit b837127 into main Dec 4, 2024
7 checks passed
@idoberko2 idoberko2 deleted the ido/opik-523-batch-delete-prompts branch December 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants