Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-152] document log level #857

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Conversation

idoberko2
Copy link
Contributor

@idoberko2 idoberko2 commented Dec 11, 2024

Details

This PR adds documentation to config.yml and config-test.yml.
In addition, found a typo and wrong environment variable name in OpenAI LLM provider and fixed it - @andrescrz FYI.

Issues

OPIK-152

@idoberko2 idoberko2 self-assigned this Dec 11, 2024
@idoberko2
Copy link
Contributor Author

@andrescrz, would love to have your input before moving on with the configuration documentation

@idoberko2
Copy link
Contributor Author

The idea is having the same structure to the rest of configuration

@andrescrz
Copy link
Collaborator

@idoberko2 the structure LGTM. Feel free to add a single top level link to the Dropwizard reference.

@idoberko2 idoberko2 force-pushed the ido/opik-152-config-documentation branch from 68bd22d to 8d859dc Compare December 15, 2024 16:05
@idoberko2 idoberko2 force-pushed the ido/opik-152-config-documentation branch from 8d859dc to 02ffca3 Compare December 16, 2024 12:33
@idoberko2 idoberko2 marked this pull request as ready for review December 16, 2024 13:03
@idoberko2 idoberko2 requested a review from a team as a code owner December 16, 2024 13:03
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the OpenAi fix!

@idoberko2 idoberko2 merged commit 8784922 into main Dec 17, 2024
7 checks passed
@idoberko2 idoberko2 deleted the ido/opik-152-config-documentation branch December 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants