-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-573] Implement get_experiment_by_[name, id] and implement Experiment.get_items() #868
Merged
alexkuzmik
merged 20 commits into
main
from
OPIK-573-fr-get-evaluation-outputs-no-client-get-experiment
Dec 13, 2024
Merged
[OPIK-573] Implement get_experiment_by_[name, id] and implement Experiment.get_items() #868
alexkuzmik
merged 20 commits into
main
from
OPIK-573-fr-get-evaluation-outputs-no-client-get-experiment
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if experiment was not found
alexkuzmik
changed the title
[OPIK-573] Implement get_experiment_by_name and implement Experiment.get_items()
[OPIK-573] Implement get_experiment_by_[name, id] and implement Experiment.get_items()
Dec 12, 2024
japdubengsub
previously approved these changes
Dec 12, 2024
Hi @alexkuzmik Can we update the definition for
|
japdubengsub
approved these changes
Dec 13, 2024
alexkuzmik
deleted the
OPIK-573-fr-get-evaluation-outputs-no-client-get-experiment
branch
December 13, 2024 12:59
Lothiraldan
added a commit
that referenced
this pull request
Dec 17, 2024
Lothiraldan
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Access to existing experiment
It is now possible to get
Experiment
instance for an experiment that already exists.Experiment methods updates
experiment.insert
has been changed to:where
ExperimentItemReferences
is a dataclassIt emphasizes that experiment items are essentialy just dataset items and traces linked together, and it is not possible to create an experiment item by manually specifying its content.
experiment.get_items()
. It returns a list ofExperimentItemContent
objects.New names in the opik namespace
ExperimentItemReferences
andExperimentItemContent
were added toopik.__all__
list.Issues
Resolves (#851)
Testing
Unit tests and e2e tests were updated.
Documentation
Docstrings added.