[Online Scoring] Automation Rules endpoints #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data model, DAO, service layer and endpoints for Automation Rule Evaluators. I've started with a more complicated approach, but in the end decided for a much simpler one which hopefully is easy enough to extend later into non-evaluator automation rules. Also as we've decided for a non-validation approach in the code, we're just going with a text field. ## Issues OPIK-590 OPIK-591
andrescrz
reviewed
Dec 20, 2024
There was a problem hiding this comment.
As discussed in the design, the rule, action and evaluator can be up to 3 different entities. Fine to go with an approach where they're all collapsed into 1 in order to deliver faster. However, this can make extendability for future requirements harder.
For this PR, focus on making the evaluator payload a polymorphic value, so we can define any type of evaluator (python, llm as a judge). The current code field of type string is a concerning implementation.
Then review a bit the paths of the new resource and adjust them.
Everything else is minor polishings. I didn't go in the tests deeply, as still commented out and because this is in-progress.
Thank you very much for putting this together and congrats for your first PR in Opik!
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Show resolved
Hide resolved
...end/src/main/java/com/comet/opik/api/resources/v1/priv/AutomationRuleEvaluatorsResource.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/AutomationRuleDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/AutomationRuleService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/AutomationRuleService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/AutomationRuleService.java
Outdated
Show resolved
Hide resolved
...d/src/main/resources/liquibase/db-app-state/migrations/000008_add_automation_rule_tables.sql
Outdated
Show resolved
Hide resolved
…o be based in a sample
…rogramming in case the string changes.
andrescrz
reviewed
Dec 23, 2024
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorUpdate.java
Outdated
Show resolved
Hide resolved
...end/src/main/java/com/comet/opik/api/resources/v1/priv/AutomationRuleEvaluatorsResource.java
Outdated
Show resolved
Hide resolved
...end/src/main/java/com/comet/opik/api/resources/v1/priv/AutomationRuleEvaluatorsResource.java
Outdated
Show resolved
Hide resolved
...end/src/main/java/com/comet/opik/api/resources/v1/priv/AutomationRuleEvaluatorsResource.java
Show resolved
Hide resolved
...d/src/main/resources/liquibase/db-app-state/migrations/000009_add_automation_rule_tables.sql
Outdated
Show resolved
Hide resolved
...d/src/main/resources/liquibase/db-app-state/migrations/000009_add_automation_rule_tables.sql
Outdated
Show resolved
Hide resolved
...d/src/main/resources/liquibase/db-app-state/migrations/000009_add_automation_rule_tables.sql
Outdated
Show resolved
Hide resolved
...d/src/main/resources/liquibase/db-app-state/migrations/000009_add_automation_rule_tables.sql
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Data model, DAO, service layer and endpoints for Automation Rule Evaluators.
We're using a polymorphic type for the evaluator code, which at least for now for LLM-as-Judge, we will use a JsonNode type
Issues
OPIK-590
OPIK-591
Testing
Documentation