[OPIK-610] multi models support and anthropic implementation #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
reviewed
Dec 24, 2024
There was a problem hiding this comment.
This looks in the good direction in my opinion.
I encourage to keep abstracting the minimum parts that differ per LLM provider, mostly the client instantiation, the calls (normal and streaming) and converting requests and responses from/to the OpenAI format.
Everything out of this, leave it in common classes/services, no need for interfacing them if not needed. This is to avoid unnecessary complexity.
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderFactory.java
Outdated
Show resolved
Hide resolved
.../opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderStreamHandler.java
Outdated
Show resolved
Hide resolved
|
+1 to Andres's comment, there's still a lot that can be moved to a common ancestor class. |
|
Do you think it's still relevant to the latest version? |
idoberko2
force-pushed
the
ido/opik-610-support-anthropic-models
branch
from
8b7025b to
3bfb047
Compare
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderFactory.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/OpenAi.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/OpenAi.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ChatCompletionService.java
Outdated
Show resolved
Hide resolved
idoberko2
force-pushed
the
ido/opik-610-support-anthropic-models
branch
from
89ae5d8 to
33481ac
Compare
idoberko2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR sets the necessary abstractions in order to introduce additional LLM providers to the chat completion resource logic.
In addition, it adds Anthropic as another LLM provider.
Some things to point out:
maxCompletionTokensto have a value. Therefore, a validation is added. It will probably require some FE changesANTHROPIC_API_KEYenvironment variable is setconfig-test.ymlhad some invalid values and so parsing them in one of the tests failed. The config file is fixed in this PRIssues
OPIK-610