Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest RocksDB and OS-provided leveldb #97

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

thanethomson
Copy link
Contributor

Based on and supersedes #95.

We need to actually update to RocksDB 8 in order to apply #95, which is what I've done in this PR.

Also, since the latest published version of leveldb is from 2021, it exists as a package in Debian Bookworm (and most other OS's), so it doesn't seem necessary to build it from source.

dependabot bot and others added 3 commits December 1, 2023 12:39
Bumps [github.com/linxGnu/grocksdb](https://github.com/linxGnu/grocksdb) from 1.7.16 to 1.8.6.
- [Release notes](https://github.com/linxGnu/grocksdb/releases)
- [Commits](linxGnu/grocksdb@v1.7.16...v1.8.6)

---
updated-dependencies:
- dependency-name: github.com/linxGnu/grocksdb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the dependencies Pull requests that update a dependency file label Dec 1, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review December 1, 2023 14:02
@thanethomson thanethomson requested a review from a team as a code owner December 1, 2023 14:02
@thanethomson thanethomson changed the title ci: Update to latest RocksDB and OS-provided leveldb Update to latest RocksDB and OS-provided leveldb Dec 1, 2023
Copy link
Member

@hvanz hvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thanethomson thanethomson added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 1ecf629 Dec 1, 2023
8 checks passed
@thanethomson thanethomson deleted the thane/update-dbs branch December 1, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants