Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BootstrapState use custom genesis doc provider (backport: #2791) #2793

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Apr 12, 2024

The cosmos-sdk 0.50 genesis doc marshalling not being compatible with the cometbft default one (see cosmos/cosmos-sdk#18477), so we need to support custom genesis doc provider in this public API as well, it's called by the bootstrap-state command in cosmos-sdk.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

…ft#2791)

The cosmos-sdk 0.50 genesis doc marshalling not being compatible with the
cometbft default one (see cosmos/cosmos-sdk#18477),
so we need to support custom genesis doc provider in this public API as well,
it's called by the `bootstrap-state` command in cosmos-sdk.
@yihuang yihuang requested a review from a team as a code owner April 12, 2024 06:33
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

node/node.go Show resolved Hide resolved
@andynog andynog merged commit 1f67e39 into cometbft:v0.38.x Apr 12, 2024
18 checks passed
@yihuang yihuang deleted the v0.38.x branch April 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants