Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(adr-116): modular crypto #3249

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs(adr-116): modular crypto #3249

wants to merge 2 commits into from

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 12, 2024

Refs #2424


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@melekes melekes added the documentation Improvements or additions to documentation label Jun 12, 2024
@melekes melekes self-assigned this Jun 12, 2024
@zmanian
Copy link

zmanian commented Jun 17, 2024

Many of the advantages of alternate cryptography require more invasive changes to the code base and even the header structure.

For instance to get advantages from BLS-12-381, you also need to be able use aggregated public keys in the commit certificates.

There are wins like a more EVM verification friendly comet that uses keccack and ethsign for signatures that can maybe be done without a hard fork.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Jun 28, 2024
@github-actions github-actions bot closed this Jul 2, 2024
@melekes melekes reopened this Jul 3, 2024
@melekes melekes added the wip Work in progress label Jul 3, 2024
Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although still very preliminary, I support this approach

Comment on lines +39 to +42
Ed25519 SignatureScheme = 1 + iota
Secp256k1
Sr25519
Bls12381 // import github.com/cometbft/bls12381
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use the KeyType (a string) that every crypto package must define, and which is supposed to be unique. Examples here, here, or here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation stale For use by stalebot wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants