build(deps): Bump github.com/cometbft/cometbft-db from 0.7.0 to 0.8.0

[dependabot]

Bumps github.com/cometbft/cometbft-db from 0.7.0 to 0.8.0.

Release notes

Sourced from github.com/cometbft/cometbft-db's releases.

v0.8.0

📖 CHANGELOG

Changelog

Sourced from github.com/cometbft/cometbft-db's changelog.

v0.8.0

Apr 26, 2023

This release bumps the supported version of RocksDB, which requires cometbft-db RocksDB users to update their builds (and hence requires a "major" release, but does not introduce any other breaking changes). Special thanks to @​yihuang for this update!

While the minimum supported version of the Go compiler was bumped to 1.19, no 1.19-specific code changes were introduced and this should, therefore, still be able to be compiled with earlier versions of Go. It is, however, recommended to upgrade to the latest version(s) of Go ASAP.

COMPILER

• Bump minimum Go version to 1.19 (#40)

DEPENDENCIES

• Update to the latest version of golang.org/x/net (#40)
• Switch rocksdb binding from gorocksdb to grocksdb, bump librocksdb dependency to v7.10.2 (#42)

Commits

• 1b1d8ed Release v0.8.0 (#55)
• cea6dcf build(deps): bump actions/stale from 7 to 8 (#52)
• 3a99e92 use grocksdb to support latest version of rocksdb (#42)
• 317cc9f Create SECURITY.md (#53)
• 7de880c build(deps): bump docker/setup-buildx-action from 2.4.1 to 2.5.0 (#47)
• 056a2af ci: Build Docker image during test (#50)
• a9928b2 build(deps): bump actions/setup-go from 3 to 4 (#48)
• 816127f Set up CodeQL
• 0584510 lint tests (#39)
• caecaa2 build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (#41)
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[thanethomson]

The reason for this failure, afaict, is that the golang:1.20 Docker base image (see https://hub.docker.com/_/golang) used for our E2E tests is based on Debian Bullseye, and the version of librocksdb-dev that comes with Bullseye is currently only v6 (see https://packages.debian.org/bullseye/librocksdb-dev), whereas now cometbft-db v0.8.0 requires v7 (only available in the "testing" version of Debian, not yet in stable).

This isn't an urgent update, and users can choose to override the dependency, so we can always punt this update to a later stage when Debian Bookworm's released. Alternatively, in the meantime we could either:

1. Manually build the rocksdb libraries in the E2E image from source, but this will slow down those E2E node image builds substantially for every new pull request to main.
2. Create and upload a new base image for our E2E app based on golang:1.20 where we manually build the rocksdb libraries from source as in (1), and then use this base image for our E2E node instead of using golang:1.20 directly. This image would need to be tied to the branch on which it's used, e.g. cometbft/e2e-base:main for the main branch, or cometbft/e2e-base:v0.39.x once we cut a v0.39.x backport branch.

Punting is, of course, the easiest short-term option. Option (2) is the best, most sustainable option (especially since it allows us more control over our E2E node's dependencies), but it's also the most expensive in terms of time/effort.

[lasarojc]

What about using the bookworm version in the meantime?
It may not be ready for production, but should be fine for our e2e tests.

[thanethomson]

What about using the bookworm version in the meantime?

If you look at the list of official Go images here, you'll see there are none that're based on Bookworm yet. So we'd have to build our own custom base image anyways.

[lasarojc]

Thanks, @thanethomson
Agree with you that 2 is better but will cost us more time. Maybe we can amortize its cost by also using it for protobuf generation.

[andynog]

Look like Bookworm will be released in first quarter of June , There's a Docker image already for Bookworm , even if it's not official, could we use it for E2E tests ? Or for option #2, are we able to come up with a solution in less than a month ? If so, may be a good route, otherwise just wait it to be released (but a month might be too long)

we need to wait for the new docker image.

[thanethomson]

@dependabot rebase

[lasarojc]

@dependabot rebase

[thanethomson]

Attempting to build this with the golang:1.20-bookworm image still results in build failure. The only way I can get the build to work is if I add instructions to the E2E Dockerfile to build RocksDB from scratch, explicitly building support for RocksDB v7.10.2, as per https://github.com/cometbft/cometbft-db/blob/6473b40574da7d6273c6e916926e2a2bff1808a7/tools/Dockerfile#L35-L44

My only intuition here is that, looking at the grocksdb releases, you have to use the libraries for RocksDB v7.10.2, which aren't actually included in Debian Bookworm (Bookworm only offers v7.8.3).

One option here is to base our E2E image on main on the cometbft-db-testing image, which has cleveldb and RocksDB manually pre-built. We would, however, probably need to bump the base Go version of the cometbft-db-testing image to 1.20.

Manually building RocksDB into our E2E image isn't an option here because it takes a very long time to build.

[lasarojc]

@dependabot rebase

[thanethomson]

Superseded by #1725.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.