Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues#925 #931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

donrestarone
Copy link

Summary

Fixing this issue: #925

TL;DR Looks like we don't have to use the option combine_options: to pass the hash that is returned by Comfy::Cms::File::VARIANT_SIZE[:thumb]

@donrestarone
Copy link
Author

PS: Not sure if Im the only who experienced this but activestorage has changed from under us. I included the migration along with the fix for posterity. I'd be happy to remove it if isn't within scope 👍

@Fodoj
Copy link

Fodoj commented Jul 13, 2021

You should also change it at least here -

{ thumb: url_for(file.attachment.variant(combine_options: Comfy::Cms::File::VARIANT_SIZE[:redactor])),
. I would not add those migrations though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants