-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add load 3d node support #5564
add load 3d node support #5564
Conversation
@comfyanonymous PTAL, the frontend PRs are already merged. We should have this PR merged on next frontend sync this Friday. |
ddf54e5
to
22bfcd6
Compare
0af7a46
to
2dacd69
Compare
e783772
to
5b1fb8d
Compare
This node can be a revolution on how we use comfy. Is it going to be implemented any time soon?? |
@comfyanonymous PTAL. I do think @jtydhr88 should become the owner of these nodes, i.e. we don't try to understand every detail of the implementation and when issue pop-up we just do necessary reverts and assign issue to the owner. |
comfy_extras/nodes_load_3d.py
Outdated
return output_image, output_mask, model_file, | ||
|
||
class Preview3D(): | ||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this node need to be in the backend? Can it be a frontend only node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I think so.
let me check and give you back soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I think so. let me check and give you back soon
Let's just remove that Preview3D node for now and get this PR merged. We can decide how to handle that Preview3D node later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, I will work on how to implement Preview3D on FE only
Great news! Does this mean we can start using it when we update comfy ? |
so cool, just want to try comfyui. thanks Terry. (太酷啦,正好想试着用用comfyui。感谢Terry) |
Yes! please update to the latest! |
Great thanks!!! |
Hi,
I implment a node to load local 3d models, here is FE change:
Comfy-Org/ComfyUI_frontend#1563
which needs this BE changes.
here are the introduction video as your reference:
1.load-3d-intro-width-height.mp4
2.load-3d-intro-showGrid-cameraType-View.mp4
3.load-3d-intro-material-lightIntensity.mp4
4.load-3d-intro-fbx-animation.mp4
5.load-3d-intro-param-up-direction.mp4
8.preview-3d-node-intro.mp4