add_model_folder_path: ensure unique paths by removing duplicates #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigcat88 <bigcat88@icloud.com>
|
This is a very confusing way to solve this problem. Can you just not add it at all to the list? I feel like this would be less confusing. Also if you could add a unit test for your change that would be great. |
bigcat88
requested review from
yoland68,
robinjhuang,
huchenlei,
pythongosssss,
ltdrdata and
Kosinkadink
as code owners
rewritten as you wished and added tests. |
huchenlei
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are small enough not to complicate the code.
Just added a check if such a path value already exists in
folder_names_and_paths- then first the old value is deleted and then the new one is added.Ideally, it would be possible to check whether it is necessary to delete and add at all, but there would be more code, and apparently it will not work faster because of several additional checks and it will become much less readable.