Replace print with logging #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested review from
yoland68,
robinjhuang,
pythongosssss,
ltdrdata,
Kosinkadink,
webfiltered and
comfyanonymous
as code owners
robinjhuang
previously approved these changes
Dec 20, 2024
webfiltered
previously approved these changes
Dec 20, 2024
huchenlei
dismissed stale reviews from webfiltered and robinjhuang
via
34eced3
huchenlei
commented
Dec 20, 2024
| @@ -754,7 +754,6 @@ def concat_cond(self, **kwargs): | |||
| mask = torch.ones_like(noise)[:, :1] | |||
|
|
|||
| mask = torch.mean(mask, dim=1, keepdim=True) | |||
| print(mask.shape) | |||
There was a problem hiding this comment.
Cleanup debug logs.
| @@ -160,7 +160,6 @@ def __init__( | |||
| if isinstance(self.num_classes, int): | |||
| self.label_emb = nn.Embedding(num_classes, time_embed_dim) | |||
| elif self.num_classes == "continuous": | |||
| print("setting up linear c_adm embedding layer") | |||
There was a problem hiding this comment.
Cleanup debug logs.
| @@ -518,7 +519,6 @@ def multistep_uni_pc_vary_update(self, x, model_prev_list, t_prev_list, t, order | |||
| A_p = C_inv_p | |||
|
|
|||
| if use_corrector: | |||
| print('using corrector') | |||
There was a problem hiding this comment.
Cleanup debug logs.
huchenlei
force-pushed
the
replace_print
branch
from
34eced3 to
e8274e9
Compare
huchenlei
commented
Dec 20, 2024
| @@ -41,8 +41,7 @@ def encode_token_weights(self, token_weight_pairs): | |||
| to_encode.append(self.gen_empty_tokens(self.special_tokens, max_token_len)) | |||
| else: | |||
| to_encode.append(gen_empty_tokens(self.special_tokens, max_token_len)) | |||
| print(to_encode) | |||
There was a problem hiding this comment.
Cleanup debugging print added in #6055.
webfiltered
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces ruff lint rule
T201that bans usage ofprint. All existing usage ofprintin core are replaced withlogging. All usages in tests/deployment files are annotated with# noqa.