Add node for regex replace(sub) operation #8340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JettHu
requested review from
Kosinkadink,
christian-byrne,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
christian-byrne
previously approved these changes
May 30, 2025
Collaborator
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
LGTM. I tested by tring the various input options with valid and invalid regex patterns:
regex-replace-local-testing.mp4
add tooltips Co-authored-by: Christian Byrne <abolkonsky.rem@gmail.com>
christian-byrne
approved these changes
May 30, 2025
webfiltered
reviewed
May 30, 2025
Collaborator
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
Would it make sense to merge the match/replace nodes with a toggle? Ref: #7952
adlerfaulkner
pushed a commit
to LucaLabsInc/ComfyUI
that referenced
this pull request
Oct 16, 2025
* Add node for regex replace(sub) operation * Apply suggestions from code review add tooltips Co-authored-by: Christian Byrne <abolkonsky.rem@gmail.com> * Fix indentation --------- Co-authored-by: Christian Byrne <abolkonsky.rem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a RegexReplace node with behavior similar to Python's re.sub