Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort #331

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Add isort #331

merged 1 commit into from
Feb 25, 2022

Conversation

jmsmkn
Copy link
Member

@jmsmkn jmsmkn commented Feb 25, 2022 •
edited
Loading

This PR adds isort with the following changes:

  • default_language_version removed
  • pyupgrade args set correctly
  • isort added before black
  • flake8-import-order removed
  • known_first_party set correctly
  • application-import-names and import-order-style removed

chrisvanrun
chrisvanrun approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@chrisvanrun chrisvanrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmsmkn jmsmkn merged commit 8f1ec64 into master Feb 25, 2022
@jmsmkn jmsmkn deleted the isort branch February 25, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvanrun chrisvanrun chrisvanrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmsmkn @chrisvanrun