Remember FlexibleImageWidget choice on form redisplay #3681
Conversation
ammar257ammar
changed the title
| hx-include="[id='values-{{ widget.name }}']" | ||
| > | ||
| {% if widget.attrs.current_value %} | ||
| <option value="{{ widget.attrs.current_value.image.pk }}">{{ widget.attrs.current_value }}</option> | ||
| <option value="{{ widget.attrs.current_value.pk }}">{{ widget.attrs.current_value.title }}</option> |
There was a problem hiding this comment.
For my understanding: we don't actually use the value of this anywhere, do we? Could it then just be left empty or set to one of the two widget choice types below (depending on the type)?
There was a problem hiding this comment.
This value is sent on submission in edit views (where the image is already saved in database) and in form redisplay upon validation error.
There was a problem hiding this comment.
I made the change in Add WidgetChoice for selected image for semantic consistency
It is not much change but semantically makes more sense instead of printing the pk value without using it anywhere.
| Image.objects.filter(pk=current_value).exists() | ||
| or UserUpload.objects.filter(pk=current_value).exists() | ||
| elif ( | ||
| widget_name == WidgetChoices.IMAGE_SELECTED.name |
There was a problem hiding this comment.
This part of the condition will work anyway without checking for widget_name value, but it is more robust to check for it.
closes #3558