Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet #59

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add wallet #59

merged 1 commit into from
Aug 12, 2021

Conversation

rishflab
Copy link
Member

No description provided.

@rishflab rishflab linked an issue Aug 10, 2021 that may be closed by this pull request
8 tasks
@rishflab rishflab requested review from thomaseizinger, luckysori and DeliciousHair and removed request for thomaseizinger August 11, 2021 00:01
Copy link
Collaborator

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rishflab for all of this work!

I've left notes on the overall structure of the workspace, but I think this is basically all we needed for #30.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Before you release, it would be good to clean-up the public API a bit but for now, we can definitely merge this so this giant chunk of work is done 🥳

self.secret_key
}

pub fn compute_balances(&self) -> Vec<BalanceEntry> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these functions need tests at some point.

Wallet which allows users to select coins through a backend configured
by them via the `GetTxOuts` trait. The provided wallet comes with a
UTXO cache which this is updated using `Wallet::sync`. This allows
users of the library to optimise the number of requests to their
backend. Users can also sign said UTXOs by calling `Wallet::sign`.
@rishflab rishflab merged commit 6019072 into master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the stateless wallet code from waves to baru
3 participants