Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manual balance and withdraw commands to CLI #694

Closed
thomaseizinger opened this issue Aug 26, 2021 · 0 comments · Fixed by #704
Closed

Add manual balance and withdraw commands to CLI #694

thomaseizinger opened this issue Aug 26, 2021 · 0 comments · Fixed by #704
Labels
good first issue Good for newcomers loss-of-funds Critical bug which can result in loss of funds

Comments

@thomaseizinger
Copy link
Contributor

Ideally, we would guarantee that the CLI never holds funds after a swap.

In practice, there are quite a few situations in which this can happen. To give users more control, a balance and withdraw command could be added.

cc @da-kami :)
@thomaseizinger thomaseizinger added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2021
@rishflab rishflab added loss-of-funds Critical bug which can result in loss of funds and removed enhancement New feature or request labels Aug 27, 2021
This was referenced Aug 29, 2021
Closed
Merged
@rishflab rishflab self-assigned this Aug 30, 2021
@rishflab rishflab linked a pull request Aug 30, 2021 that will close this issue
Allow withdrawing and viewing of the bitcoin balance on swap-cli #704
Merged
@rishflab rishflab removed their assignment Aug 31, 2021
bors bot added a commit that referenced this issue Sep 1, 2021
@bors
Merge #704
51d8623 
704: Allow withdrawing and viewing of the bitcoin balance on swap-cli r=rishflab a=devbordecraft

Same mechanics of the ASB but on swap-cli as discussed in #694

Co-authored-by: devbordecraft <devbordecraft>
@bors bors bot closed this as completed in #704 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers loss-of-funds Critical bug which can result in loss of funds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow withdrawing and viewing of the bitcoin balance on swap-cli
2 participants
@thomaseizinger @rishflab