memory leak when loggerd/encoderd get out of sync

[adeebshihadeh]

No description provided.

[adeebshihadeh]

@deanlee want to look into this?

[deanlee]

looks like we need to reset the LoggerdState when get out of sync, including clearing the old packages that are in the queue.otherwise it will cause endless recursive calls.

[deanlee]

already submitted two PRs to address the memory leak issues:

#28873
#28697

It may require a few more PRs to improve the stability of loggerd.

[adeebshihadeh]

Do we need both? What's the smallest possible fix for the current issue?

[deanlee]

#28873 is for the current issue.

the smallest possible quick and dirty fix could be something like this :#28901

but I strongly recommend use #28873. the recursive call is buggy and dangerous. we really should refactoring loggerd instead of just keeping it working as it is.

[adeebshihadeh]

I see, this is a big change to get in the upcoming release. I'll check out the fix you prefer after we ship this one.