Improve typespecs #121
Merged
Improve typespecs #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta data can be nil. And data and metadata will only be serialized into binary on store.
Postgrex.query/4 has the following typespecs:
query(conn(), iodata(), list(), Keyword.t()) ::
{:ok, Postgrex.Result.t()} |
{:error, Postgrex.Error.t()}
So this function would never be called as both return values are handled
in the other functions.
|
Great work, thank you @OleMchls. I'll keep an eye on when you're ready for the PR to be merged. |
|
@slashdotdash I fixed one warning and ignored the other, so I think this PR is good to be merged. I updated the initial ticket to reflect the current state. Let me know if you have any feedback you would want to see addressed. |
|
@slashdotdash Together with the incredible 🎉 @coreyhaines I fixed the last remaining build breaker. We also removed the ignored warning and rather had the issue fixed upstream in |
|
Thanks for taking the time to get this fixed @OleMchls. |
slashdotdash
added a commit
that referenced
this pull request
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #120 this PR addresses some typespec errors.
Thw work on this triggered two two tickets in their respective repos: sasa1977/fsm#10 & jeremyjh/dialyxir#192
fixes #120
Update 06/14/2018: removed fixed no return error
Update 06/14/2018: update to declare it ready to be merged
Update 06/14/2018: reflect updated fsm